Skip to content

Add default (mold, array_size) overloads for rvs_normal #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add default (mold, array_size) overloads for rvs_normal #1056

wants to merge 2 commits into from
+76 −0

Conversation

@gururaj1512
Copy link

@gururaj1512 gururaj1512 commented Nov 12, 2025

Resolves #963

  • Add convenience overloads for rvs_normal that accept (mold, array_size) and return standard-normal arrays (loc=0, scale=1) for both real and complex kinds.
  • Add deterministic tests that compare the new (mold, array_size) call with the explicit (loc=0, scale=1, array_size) call to ensure identical behavior.

@gururaj1512
Copy link
Author

gururaj1512 commented Nov 12, 2025

@jvdp1, Can you have a look. Needs review...!

jvdp1
jvdp1 reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gururaj1512 . I have some suggestions below.

@gururaj1512
Copy link
Author

gururaj1512 commented Nov 15, 2025

@jvdp1, I've refactored as per your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvdp1 jvdp1 jvdp1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make loc and scale arguments of rvs_normal optional when returning an array

2 participants

@gururaj1512 @jvdp1